Use file:// protocol for cloning under test

asottile · asottile · commit 989bcfe9ca61 · 2017-09-22T10:38:19.000-07:00
diff --git a/pre_commit/languages/golang.py b/pre_commit/languages/golang.py
@@ -37,8 +37,11 @@ def in_env(repo_cmd_runner):
 def guess_go_dir(remote_url):
     if remote_url.endswith('.git'):
         remote_url = remote_url[:-1 * len('.git')]
+    looks_like_url = (
+        not remote_url.startswith('file://') and
+        ('//' in remote_url or '@' in remote_url)
+    )
     remote_url = remote_url.replace(':', '/')
-    looks_like_url = '//' in remote_url or '@' in remote_url
     if looks_like_url:
         _, _, remote_url = remote_url.rpartition('//')
         _, _, remote_url = remote_url.rpartition('@')
diff --git a/testing/fixtures.py b/testing/fixtures.py
@@ -83,7 +83,7 @@ def config_with_local_hooks():
 def make_config_from_repo(repo_path, sha=None, hooks=None, check=True):
     manifest = load_manifest(os.path.join(repo_path, C.MANIFEST_FILE))
     config = OrderedDict((
-        ('repo', repo_path),
+        ('repo', 'file://{}'.format(repo_path)),
         ('sha', sha or get_head_sha(repo_path)),
         (
             'hooks',
diff --git a/tests/languages/golang_test.py b/tests/languages/golang_test.py
@@ -10,6 +10,7 @@
     ('url', 'expected'),
     (
         ('/im/a/path/on/disk', 'unknown_src_dir'),
+        ('file:///im/a/path/on/disk', 'unknown_src_dir'),
         ('git@github.com:golang/lint', 'github.com/golang/lint'),
         ('git://github.com/golang/lint', 'github.com/golang/lint'),
         ('http://github.com/golang/lint', 'github.com/golang/lint'),
diff --git a/tests/repository_test.py b/tests/repository_test.py
@@ -714,7 +714,7 @@ def test_hook_id_not_present(tempdir_factory, store, fake_log_handler):
     with pytest.raises(SystemExit):
         repo.require_installed()
     assert fake_log_handler.handle.call_args[0][0].msg == (
-        '`i-dont-exist` is not present in repository {}.  '
+        '`i-dont-exist` is not present in repository file://{}.  '
         'Typo? Perhaps it is introduced in a newer version?  '
         'Often `pre-commit autoupdate` fixes this.'.format(path)
     )

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ def config_with_local_hooks():`
`83`	`83`	`def make_config_from_repo(repo_path, sha=None, hooks=None, check=True):`
`84`	`84`	`manifest = load_manifest(os.path.join(repo_path, C.MANIFEST_FILE))`
`85`	`85`	`config = OrderedDict((`
`86`		`- ('repo', repo_path),`
	`86`	`+ ('repo', 'file://{}'.format(repo_path)),`
`87`	`87`	`('sha', sha or get_head_sha(repo_path)),`
`88`	`88`	`(`
`89`	`89`	`'hooks',`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`('url', 'expected'),`
`11`	`11`	`(`
`12`	`12`	`('/im/a/path/on/disk', 'unknown_src_dir'),`
	`13`	`+ ('file:///im/a/path/on/disk', 'unknown_src_dir'),`
`13`	`14`	`('git@github.com:golang/lint', 'github.com/golang/lint'),`
`14`	`15`	`('git://github.com/golang/lint', 'github.com/golang/lint'),`
`15`	`16`	`('http://github.com/golang/lint', 'github.com/golang/lint'),`
Original file line number	Diff line number	Diff line change
`@@ -714,7 +714,7 @@ def test_hook_id_not_present(tempdir_factory, store, fake_log_handler):`
`714`	`714`	`with pytest.raises(SystemExit):`
`715`	`715`	`repo.require_installed()`
`716`	`716`	`assert fake_log_handler.handle.call_args[0][0].msg == (`
`717`		- '`i-dont-exist` is not present in repository {}. '
	`717`	+ '`i-dont-exist` is not present in repository file://{}. '
`718`	`718`	`'Typo? Perhaps it is introduced in a newer version? '`
`719`	`719`	'Often `pre-commit autoupdate` fixes this.'.format(path)
`720`	`720`	`)`