Convert LoggingHandler to use sys.stdout.write

asottile · asottile · commit 374ef758358c · 2014-04-13T18:36:14.000-07:00
diff --git a/pre_commit/logging_handler.py b/pre_commit/logging_handler.py
@@ -1,6 +1,5 @@
-from __future__ import print_function
-
 import logging
+import sys
 
 from pre_commit import color
 
@@ -14,14 +13,14 @@
 
 
 class LoggingHandler(logging.Handler):
-    def __init__(self, use_color, print_fn=print):
+    def __init__(self, use_color, write=sys.stdout.write):
         logging.Handler.__init__(self)
         self.use_color = use_color
-        self.__print_fn = print_fn
+        self.__write = write
 
     def emit(self, record):
-        self.__print_fn(
-            u'{0}{1}'.format(
+        self.__write(
+            u'{0}{1}\n'.format(
                 color.format_color(
                     '[{0}]'.format(record.levelname),
                     LOG_LEVEL_COLORS[record.levelname],
diff --git a/tests/logging_handler_test.py b/tests/logging_handler_test.py
@@ -19,7 +19,7 @@ def test_logging_handler_color():
     handler = LoggingHandler(True, print_mock)
     handler.emit(FakeLogRecord('hi', 'WARNING', 30))
     print_mock.assert_called_once_with(
-        color.YELLOW + '[WARNING]' + color.NORMAL + ' hi',
+        color.YELLOW + '[WARNING]' + color.NORMAL + ' hi\n',
     )
 
 
@@ -28,5 +28,5 @@ def test_logging_handler_no_color():
     handler = LoggingHandler(False, print_mock)
     handler.emit(FakeLogRecord('hi', 'WARNING', 30))
     print_mock.assert_called_once_with(
-        '[WARNING] hi',
+        '[WARNING] hi\n',
     )

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ def test_logging_handler_color():`
`19`	`19`	`handler = LoggingHandler(True, print_mock)`
`20`	`20`	`handler.emit(FakeLogRecord('hi', 'WARNING', 30))`
`21`	`21`	`print_mock.assert_called_once_with(`
`22`		`- color.YELLOW + '[WARNING]' + color.NORMAL + ' hi',`
	`22`	`+ color.YELLOW + '[WARNING]' + color.NORMAL + ' hi\n',`
`23`	`23`	`)`
`24`	`24`
`25`	`25`
`@@ -28,5 +28,5 @@ def test_logging_handler_no_color():`
`28`	`28`	`handler = LoggingHandler(False, print_mock)`
`29`	`29`	`handler.emit(FakeLogRecord('hi', 'WARNING', 30))`
`30`	`30`	`print_mock.assert_called_once_with(`
`31`		`- '[WARNING] hi',`
	`31`	`+ '[WARNING] hi\n',`
`32`	`32`	`)`