Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pythonarcade/arcade-accelerate
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: development
Choose a base ref
...
head repository: pythonarcade/arcade-accelerate
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: basicsprite-improvements
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 1 contributor

Commits on May 1, 2023

  1. Add sprite patching

    @cspotcode
    cspotcode committed May 1, 2023
    Configuration menu
    Copy the full SHA
    7ba2038 View commit details
    Browse the repository at this point in the history

  2. Improvements to BasicSprite rust impl: 

    Avoid cloning BasicSprite by using `PyRef` and `PyRefMut`

use `intern!` for python method names as recommended by docs: https://pyo3.rs/main/doc/pyo3/macro.intern.html

Add `_` getters as expected by `SpriteList`
Remove `impl IntoPy<Py<PyTuple>> for BasicSprite`

Release borrow of self before calling into python in `set_position`; probably need to do this elsewhere too

Clone reference to `self.texture` instead of cloning `self`; achieves same effect

Clone `sprite_lists` vector before iterating; I can't figure out how to avoid this
    @cspotcode
    cspotcode committed May 1, 2023
    Configuration menu
    Copy the full SHA
    2d0ec88 View commit details
    Browse the repository at this point in the history

  3. Update __init__.py

    @cspotcode
    cspotcode authored May 1, 2023
    Configuration menu
    Copy the full SHA
    16e5573 View commit details
    Browse the repository at this point in the history

  4. Update __init__.py

    @cspotcode
    cspotcode authored May 1, 2023
    Configuration menu
    Copy the full SHA
    53484ef View commit details
    Browse the repository at this point in the history

  5. fmt

    @cspotcode
    cspotcode committed May 1, 2023
    Configuration menu
    Copy the full SHA
    b8a60b8 View commit details
    Browse the repository at this point in the history
Loading