Skip to content

Gui/fix caret misplaced #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eruvanos merged 4 commits into from
Jul 5, 2025
Merged

Gui/fix caret misplaced #2750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec8f86c
gui: fix caret offset after UIInputText is resized
eruvanos Jul 5, 2025
399272b
gui: cleanup test execution
eruvanos Jul 5, 2025
3249467
gui: add changelog
eruvanos Jul 5, 2025
0d75925
gui: lint
eruvanos Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
You can grab pre-release versions from PyPi. See the available versions from the
Arcade [PyPi Release History](https://pypi.org/project/arcade/#history) page.

## Unreleased

- GUI
- Fix a bug, where the caret of UIInputText was misplaced after resizing the widget

## 3.3.2

- GUI
Expand Down
3 changes: 3 additions & 0 deletions arcade/gui/widgets/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,9 @@ def _update_layout(self):
layout.y = 0
layout.end_update()

# manually update caret position
self.caret.on_layout_update()

@property
def text(self):
"""Text of the input field."""
Expand Down
38 changes: 20 additions & 18 deletions tests/unit/gui/test_widget_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,23 +131,25 @@ def objs_in_memory(obj_type):
del root
gc.collect()

if objs_in_memory(UIWidget) > start_count:
print("Render object graph...")
import objgraph

objgraph.show_chain(
objgraph.find_backref_chain(
[obj for obj in gc.get_objects() if isinstance(obj, UIWidget)][1],
objgraph.is_proper_module,
),
# filename="chain.png",
)

# print("Render backrefs...")
# objgraph.show_backrefs(
# [[obj for obj in gc.get_objects() if isinstance(obj, UIWidget)][1]],
# max_depth=15,
# # filename="sample-graph.png",
# )
# This might help, if the test fails ;)
# requires `objgraph`
# if objs_in_memory(UIWidget) > start_count:
# print("Render object graph...")
# import objgraph
#
# objgraph.show_chain(
# objgraph.find_backref_chain(
# [obj for obj in gc.get_objects() if isinstance(obj, UIWidget)][1],
# objgraph.is_proper_module,
# ),
# # filename="chain.png",
# )

# print("Render backrefs...")
# objgraph.show_backrefs(
# [[obj for obj in gc.get_objects() if isinstance(obj, UIWidget)][1]],
# max_depth=15,
# # filename="sample-graph.png",
# )

assert objs_in_memory(UIWidget) == start_count
Loading