Merged
Conversation
DragonMoffon
force-pushed
the
hot-fixes
branch
from
bb115ec to
675e94d
Compare
ghost
reviewed
Jan 23, 2025
| accept_mouse_events: bool | Iterable = True, | ||
| prevent_dispatch: Iterable | None = None, | ||
| prevent_dispatch_view: Iterable | None = None, | ||
| prevent_dispatch: Iterable | bool | None = None, |
There was a problem hiding this comment.
defval can be set to {True} now, and then L99 just becomes
self.prevent_dispatch = prevent_dispatch
same for _view. This would break existing code which explicitly passes in None (can't imagine such).
Also maybe bool | Iterable vs. Iterable | bool should be consistent for readability.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
timedef during unit testsprevent_dispatcharg inSectionclass #2499)