Skip to content

feat(section): untie sections and arcade#2345

Merged
eruvanos merged 7 commits intodevelopmentfrom
untie-sections
Sep 1, 2024
Merged

feat(section): untie sections and arcade#2345
eruvanos merged 7 commits intodevelopmentfrom
untie-sections

Conversation

@eruvanos
Copy link
Member

@eruvanos eruvanos commented Aug 7, 2024 •
edited
Loading

I would like to untie arcade and sections, we have a lot of discussions about Sections in general, this PR would ease the path, what ever we decide later.

@eruvanos eruvanos mentioned this pull request Aug 21, 2024
Open
@alejcas
Copy link
Member

alejcas commented Sep 1, 2024

How are Section on_show_section and on_hide_section called for the first time?

Now that on_show_view and on_hide_view no longer exists, when the view is displayed the section manager will no longer call each section on_show_section.

Some functionality relies on this.

Maybe SectionManager.enable() should call on_show_section on each one:

for section in self.sections:
    if section.enabled:
        section.on_show_section()

Then disable the opposite.

@eruvanos
Copy link
Member Author

eruvanos commented Sep 1, 2024

SectionManager sets section.enabled = True

The property calls on_show_section() already.

arcade/arcade/sections.py

Line 149 in 23e9752

def enabled(self, value: bool):

So that should be covered.

@alejcas
Copy link
Member

alejcas commented Sep 1, 2024

SectionManager sets section.enabled = True

No, it won't work because section is enabled by default and if you set enabled to True it won't trigger anything:

arcade/arcade/sections.py

Lines 150 to 151 in 23e9752

if value is self._enabled:
return

@eruvanos
Copy link
Member Author

eruvanos commented Sep 1, 2024

Oh, I see, you are right. Will add the code you mentioned

@eruvanos
Copy link
Member Author

eruvanos commented Sep 1, 2024 

 for section in self.sections:
            # sections are enabled by default
            if section.enabled:
                section.on_show_section()
            else:
                section.enabled = True
                # enabling a section will trigger on_show_section

@eruvanos
Copy link
Member Author

eruvanos commented Sep 1, 2024

@alejcas Would you be fine if I merge this state, if you have any concerns, just let me know.

@alejcas
Copy link
Member

alejcas commented Sep 1, 2024

@alejcas Would you be fine if I merge this state, if you have any concerns, just let me know.

I think so!! go ahead

@eruvanos eruvanos merged commit d4947c9 into development Sep 1, 2024
@eruvanos eruvanos deleted the untie-sections branch September 2, 2024 21:45
DragonMoffon added a commit that referenced this pull request Sep 18, 2024
@DragonMoffon
Squashed commit of the following:
7eaaf44 
commit 0e8403a
Author: A. J. Andrews <86714785+DragonMoffon@users.noreply.github.com>
Date:   Sun Sep 15 23:19:50 2024 +1200

    fixed small issue with sprite size property

commit 851821b
Author: DigiDuncan <digiduncan@gmail.com>
Date:   Sun Sep 15 04:23:07 2024 -0400

    add .tracking and px -> em conversion (#2365)

    * add .tracking and px -> em conversion

    * I hate Sphinx

    It's coarse, and rough, and irritating, and it gets everywhere.

    * fix docs

commit 4ff2f0f
Author: DigiDuncan <digiduncan@gmail.com>
Date:   Sun Sep 15 01:27:23 2024 -0400

    add __all__ to InputManger (#2366)

commit 895bf57
Author: bump_version <bump-version@version.com>
Date:   Sun Sep 8 01:01:14 2024 +0000

     Version 3.0.0-dev.36 [skip ci]

commit 5c4bc93
Author: Einar Forselv <eforselv@gmail.com>
Date:   Sun Sep 8 01:28:44 2024 +0200

    Fix uilabel tests on windows (#2362)

commit 798ae21
Author: Maic Siemering <maic@siemering.tech>
Date:   Mon Sep 2 23:54:23 2024 +0200

    fix slider calculates wrong x value when min_value > 0 (#2359)

commit d4947c9
Author: Maic Siemering <maic@siemering.tech>
Date:   Sun Sep 1 23:32:04 2024 +0200

    feat(section): untie sections and arcade (#2345)

    * feat(section): untie sections and arcade

commit e9dd36a
Author: bump_version <bump-version@version.com>
Date:   Sun Sep 1 16:59:51 2024 +0000

     Version 3.0.0-dev.35 [skip ci]

commit a362ee1
Author: Maic Siemering <maic@siemering.tech>
Date:   Sat Aug 31 23:00:08 2024 +0200

    Changes for arcade 3.0 RC2 (dev34) (#2357)

    - Add more gui examples
      - hidden password
      - camera
    - revamp UIGridLayout, use box algorithm, add documentation

commit 1b8ca03
Author: bump_version <bump-version@version.com>
Date:   Mon Aug 26 12:50:54 2024 +0000

     Version 3.0.0-dev.34 [skip ci]

commit 19b53a1
Author: Maic Siemering <maic@siemering.tech>
Date:   Sat Aug 24 05:43:10 2024 +0200

    Gui/colorpicker (#2354)

    * Add color picker example

commit 10143b9
Author: Maic Siemering <maic@siemering.tech>
Date:   Sat Aug 24 05:05:14 2024 +0200

    GUI push for 3.0 (#2351)

    - New FlatUI colors under arcade.uicolor
    - Combined gui examples and proper documentation
    - Rewrite box layout to address sizing issues, when a child provided size_hint_min
    - GUI assets are now consistent in style and properly structured
    - Apply feedback about UIGridLayout parameter names
    - UIView provides add_widget method and a background property, which will be used for clearing screen
    - UIFlatButton provides multiple default styles
    - Consistent UITextureSlider parameter names, better default for height
    - UIAnchorLayouts do not restrict a child size to its own size, to allow scrolling use cases
    - UITextArea provides the option for pyglet attributed or html text formatting
    - UIInputText emits a on_change event, when text changed
    - Buttons default to Kenny font, when loaded

    ---------

    Co-authored-by: Jaecktec <constantin@jaeck.eu.org>

commit 3808448
Author: Aizen <32631344+feiyuhuahuo@users.noreply.github.com>
Date:   Fri Aug 23 11:54:16 2024 +0800

    Update resource_handlers.rst (#2348)

commit 072101f
Author: A. J. Andrews <86714785+DragonMoffon@users.noreply.github.com>
Date:   Wed Aug 14 00:26:07 2024 +1200

    updated ViewportProjector to use Rect, and created unit tests (#2343)

    * updated ViewportProjector to use Rect and created unit tests

    * linting ✨

    * ⬛

    * Correcting references to the viewport

    Thanks for pointing out the issue, @eruvanos!

commit 83cb72d
Author: Maic Siemering <maic@siemering.tech>
Date:   Thu Aug 8 21:24:06 2024 +0200

    typing(gui):remove type ignores from gui (#2346)

    * remove type ignores from gui

commit f44233c
Merge: 8c17aed 2c4161f
Author: A. J. Andrews <86714785+DragonMoffon@users.noreply.github.com>
Date:   Thu Aug 8 12:43:28 2024 +1200

    Merge pull request #2344 from pythonarcade/sub-clock

    Add a SubClock class to `arcade.future`

commit 2c4161f
Author: DragonMoffon <happydog.aja@gmail.com>
Date:   Thu Aug 8 00:28:57 2024 +1200

    :sparkles: linting and :black_large_square: :sparkles:

commit be85a02
Author: DragonMoffon <happydog.aja@gmail.com>
Date:   Thu Aug 8 00:24:12 2024 +1200

    Create SubClock Class

commit b441fb9
Author: DragonMoffon <happydog.aja@gmail.com>
Date:   Thu Aug 8 00:23:59 2024 +1200

    :boot:strapping!

commit 734e333
Author: DragonMoffon <happydog.aja@gmail.com>
Date:   Thu Aug 8 00:11:52 2024 +1200

    no more doc string typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eruvanos @alejcas