Skip to content

Commit a505ecd

Browse files
authored
bpo-31676: Fix test_imp.test_load_source() side effect (python#3871)
test_load_source() now replaces the current __name__ module with a temporary module to prevent side effects.
1 parent a991215 commit a505ecd

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

‎Lib/test/test_imp.py‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,8 +310,13 @@ def test_multiple_calls_to_get_data(self):
310310
loader.get_data(imp.__file__) # Will need to create a newly opened file
311311

312312
def test_load_source(self):
313-
with self.assertRaisesRegex(ValueError, 'embedded null'):
314-
imp.load_source(__name__, __file__ + "\0")
313+
# Create a temporary module since load_source(name) modifies
314+
# sys.modules[name] attributes like __loader___
315+
modname = f"tmp{__name__}"
316+
mod = type(sys.modules[__name__])(modname)
317+
with support.swap_item(sys.modules, modname, mod):
318+
with self.assertRaisesRegex(ValueError, 'embedded null'):
319+
imp.load_source(modname, __file__ + "\0")
315320

316321
@support.cpython_only
317322
def test_issue31315(self):

0 commit comments

Comments
 (0)