Skip to content

Commit 36aff2d

Browse files
Issue python#25203: Failed readline.set_completer_delims() no longer left the
module in inconsistent state.
2 parents c944e34 + 1138439 commit 36aff2d

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

‎Misc/NEWS‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ Core and Builtins
2121
Library
2222
-------
2323

24+
- Issue #25203: Failed readline.set_completer_delims() no longer left the
25+
module in inconsistent state.
26+
2427
- Issue #23329: Allow the ssl module to be built with older versions of
2528
LibreSSL.
2629

‎Modules/readline.c‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -464,10 +464,11 @@ set_completer_delims(PyObject *self, PyObject *args)
464464
/* Keep a reference to the allocated memory in the module state in case
465465
some other module modifies rl_completer_word_break_characters
466466
(see issue #17289). */
467-
free(completer_word_break_characters);
468-
completer_word_break_characters = strdup(break_chars);
469-
if (completer_word_break_characters) {
470-
rl_completer_word_break_characters = completer_word_break_characters;
467+
break_chars = strdup(break_chars);
468+
if (break_chars) {
469+
free(completer_word_break_characters);
470+
completer_word_break_characters = break_chars;
471+
rl_completer_word_break_characters = break_chars;
471472
Py_RETURN_NONE;
472473
}
473474
else

0 commit comments

Comments
 (0)