Changes to allow each HTTP request to be a seperate thread (prometheus#139)

jamessewell · brian-brazil · commit ce5542bd8be2 · 2017-02-14T13:35:30.000Z
Allow each HTTP request to be a separate thread
diff --git a/prometheus_client/exposition.py b/prometheus_client/exposition.py
@@ -12,16 +12,16 @@
 
 from . import core
 try:
-    from BaseHTTPServer import BaseHTTPRequestHandler
-    from BaseHTTPServer import HTTPServer
+    from BaseHTTPServer import BaseHTTPRequestHandler, HTTPServer
+    from SocketServer import ThreadingMixIn
     from urllib2 import build_opener, Request, HTTPHandler
     from urllib import quote_plus
     from urlparse import parse_qs, urlparse
 except ImportError:
     # Python 3
     unicode = str
-    from http.server import BaseHTTPRequestHandler
-    from http.server import HTTPServer
+    from http.server import BaseHTTPRequestHandler, HTTPServer
+    from socketserver import ThreadingMixIn
     from urllib.request import build_opener, Request, HTTPHandler
     from urllib.parse import quote_plus, parse_qs, urlparse
 
@@ -97,10 +97,12 @@ def log_message(self, format, *args):
 
 
 def start_http_server(port, addr=''):
-    """Starts a HTTP server for prometheus metrics as a daemon thread."""
+    """Starts an HTTP server for prometheus metrics as a daemon thread"""
+    class ThreadingSimpleServer(ThreadingMixIn, HTTPServer):
+        pass
     class PrometheusMetricsServer(threading.Thread):
         def run(self):
-            httpd = HTTPServer((addr, port), MetricsHandler)
+            httpd = ThreadingSimpleServer((addr, port), MetricsHandler)
             httpd.serve_forever()
     t = PrometheusMetricsServer()
     t.daemon = True
