Skip to content

Move software carpentry up a bit#58

Merged
takluyver merged 1 commit intopython3statement:masterfrom
Carreau:swc-up
Nov 21, 2016
Merged

Move software carpentry up a bit#58
takluyver merged 1 commit intopython3statement:masterfrom
Carreau:swc-up

Conversation

@Carreau
Copy link
Copy Markdown
Member

@Carreau Carreau commented Nov 21, 2016

As requested by @takluyver .

@Carreau Carreau mentioned this pull request Nov 21, 2016
@takluyver takluyver merged commit 35f108e into python3statement:master Nov 21, 2016
@takluyver
Copy link
Copy Markdown
Member

Thanks!

@takluyver
Copy link
Copy Markdown
Member

Hmm, that logo looks a bit odd amongst the others. Too tired to have any ideas what to do with it, though.

@brettcannon
Copy link
Copy Markdown
Contributor

I think it's because the logo isn't vertically centered. Don't know what magic CSS you could do to fix that, though.

@Carreau Carreau deleted the swc-up branch November 21, 2016 23:40
@Carreau
Copy link
Copy Markdown
Member Author

Carreau commented Nov 21, 2016

I think it's because the logo isn't vertically centered. Don't know what magic CSS you could do to fix that, though.

Yeah, without heavy refactoring of the html that's going to be hard even with css you need wrapper html elements, and we'd like to keep markdown that's going to be tough.

Alternatively we can use another SWC logo , eg :

this

Which looks better:

screen shot 2016-11-21 at 15 45 33

As it has an aspect ratio closer to 1.

(need to remove the drop shadow though)

@takluyver
Copy link
Copy Markdown
Member

+1 for the two-line version of the logo, if someone has a moment to switch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants