Skip to content

Commit b0250d7

Browse files
dschadowdschadow
committed
static final LOGGER
1 parent e7e4be9 commit b0250d7

File tree

21 files changed

+119
-119
lines changed

21 files changed

+119
-119
lines changed

‎Ch04_OutputEscapingJSP/src/main/java/de/dominikschadow/webappsecurity/controller/ContactController.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@
3535
@SessionAttributes
3636
@RequestMapping(value = "/contacts")
3737
public class ContactController {
38-
private Logger logger = LoggerFactory.getLogger(getClass());
38+
private static final Logger LOGGER = LoggerFactory.getLogger(ContactController.class);
3939

4040
@RequestMapping(value = "/addContact", method = RequestMethod.POST)
4141
public String addContact(@ModelAttribute Contact contact, Model model) {
42-
logger.info("Firstname: " + contact.getFirstname() + ", Lastname: " + contact.getLastname());
42+
LOGGER.info("Firstname: " + contact.getFirstname() + ", Lastname: " + contact.getLastname());
4343

4444
model.addAttribute("contact", contact);
4545

‎Ch05_AccessReferenceMaps/src/main/java/de/dominikschadow/webappsecurity/AccountsDAO.java‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@
3131
* @see AccountController
3232
*/
3333
public class AccountsDAO {
34-
private Logger logger = LoggerFactory.getLogger(getClass());
34+
private static final Logger LOGGER = LoggerFactory.getLogger(AccountsDAO.class);
3535

3636
public AccountsDAO() {
3737
try {
3838
Class.forName("org.hsqldb.jdbcDriver");
3939
} catch (ClassNotFoundException ex) {
40-
logger.error("Failed to load db driver", ex);
40+
LOGGER.error("Failed to load db driver", ex);
4141
}
4242
}
4343

@@ -73,28 +73,28 @@ private Account queryAccount(int id) {
7373
return account;
7474
}
7575
} catch (SQLException ex) {
76-
logger.error("SQL exception", ex);
76+
LOGGER.error("SQL exception", ex);
7777
} finally {
7878
try {
7979
if (rs != null) {
8080
rs.close();
8181
}
8282
} catch (SQLException ex) {
83-
logger.error("Failed to close rs", ex);
83+
LOGGER.error("Failed to close rs", ex);
8484
}
8585
try {
8686
if (pstmt != null) {
8787
pstmt.close();
8888
}
8989
} catch (SQLException ex) {
90-
logger.error("Failed to close pstmt", ex);
90+
LOGGER.error("Failed to close pstmt", ex);
9191
}
9292
try {
9393
if (con != null) {
9494
con.close();
9595
}
9696
} catch (SQLException ex) {
97-
logger.error("Failed to close con", ex);
97+
LOGGER.error("Failed to close con", ex);
9898
}
9999
}
100100

@@ -120,28 +120,28 @@ private List<String> queryAccounts(int userId) {
120120
accountReferences.add(rs.getString(1));
121121
}
122122
} catch (SQLException ex) {
123-
logger.error("SQL exception", ex);
123+
LOGGER.error("SQL exception", ex);
124124
} finally {
125125
try {
126126
if (rs != null) {
127127
rs.close();
128128
}
129129
} catch (SQLException ex) {
130-
logger.error("Failed to close rs", ex);
130+
LOGGER.error("Failed to close rs", ex);
131131
}
132132
try {
133133
if (pstmt != null) {
134134
pstmt.close();
135135
}
136136
} catch (SQLException ex) {
137-
logger.error("Failed to close pstmt", ex);
137+
LOGGER.error("Failed to close pstmt", ex);
138138
}
139139
try {
140140
if (con != null) {
141141
con.close();
142142
}
143143
} catch (SQLException ex) {
144-
logger.error("Failed to close con", ex);
144+
LOGGER.error("Failed to close con", ex);
145145
}
146146
}
147147

‎Ch05_AccessReferenceMaps/src/main/java/de/dominikschadow/webappsecurity/AccountsIntegerDAO.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@
3434
*/
3535
public class AccountsIntegerDAO {
3636
private IntegerAccessReferenceMap accounts = new IntegerAccessReferenceMap();
37-
private Logger logger = LoggerFactory.getLogger(getClass());
37+
private static final Logger LOGGER = LoggerFactory.getLogger(AccountsIntegerDAO.class);
3838

3939
public AccountsIntegerDAO() {
4040
try {
4141
Class.forName("org.hsqldb.jdbcDriver");
4242
} catch (ClassNotFoundException ex) {
43-
logger.error("Failed to load db driver", ex);
43+
LOGGER.error("Failed to load db driver", ex);
4444
}
4545
}
4646

@@ -50,7 +50,7 @@ public Account retrieveAccount(int accountId) {
5050
try {
5151
return accounts.getDirectReference(accountReference);
5252
} catch (AccessControlException ex) {
53-
logger.error("Access to " + accountReference + " denied", ex);
53+
LOGGER.error("Access to " + accountReference + " denied", ex);
5454

5555
return null;
5656
}
@@ -86,28 +86,28 @@ private List<String> queryAccounts(User user) {
8686
accountReferences.add(accounts.getIndirectReference(account));
8787
}
8888
} catch (SQLException ex) {
89-
logger.error("SQL exception", ex);
89+
LOGGER.error("SQL exception", ex);
9090
} finally {
9191
try {
9292
if (rs != null) {
9393
rs.close();
9494
}
9595
} catch (SQLException ex) {
96-
logger.error("Failed to close rs", ex);
96+
LOGGER.error("Failed to close rs", ex);
9797
}
9898
try {
9999
if (pstmt != null) {
100100
pstmt.close();
101101
}
102102
} catch (SQLException ex) {
103-
logger.error("Failed to close pstmt", ex);
103+
LOGGER.error("Failed to close pstmt", ex);
104104
}
105105
try {
106106
if (con != null) {
107107
con.close();
108108
}
109109
} catch (SQLException ex) {
110-
logger.error("Failed to close con", ex);
110+
LOGGER.error("Failed to close con", ex);
111111
}
112112
}
113113

‎Ch05_AccessReferenceMaps/src/main/java/de/dominikschadow/webappsecurity/AccountsRandomDAO.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,21 @@
3434
*/
3535
public class AccountsRandomDAO {
3636
private RandomAccessReferenceMap accounts = new RandomAccessReferenceMap();
37-
private Logger logger = LoggerFactory.getLogger(getClass());
37+
private static final Logger LOGGER = LoggerFactory.getLogger(AccountsRandomDAO.class);
3838

3939
public AccountsRandomDAO() {
4040
try {
4141
Class.forName("org.hsqldb.jdbcDriver");
4242
} catch (ClassNotFoundException ex) {
43-
logger.error("Failed to load db driver", ex);
43+
LOGGER.error("Failed to load db driver", ex);
4444
}
4545
}
4646

4747
public Account retrieveAccount(String accountReference) {
4848
try {
4949
return accounts.getDirectReference(accountReference);
5050
} catch (AccessControlException ex) {
51-
logger.error("Access to " + accountReference + " denied", ex);
51+
LOGGER.error("Access to " + accountReference + " denied", ex);
5252

5353
return null;
5454
}
@@ -84,28 +84,28 @@ private List<String> queryAccounts(User user) {
8484
accountReferences.add(accounts.getIndirectReference(account));
8585
}
8686
} catch (SQLException ex) {
87-
logger.error("SQL exception", ex);
87+
LOGGER.error("SQL exception", ex);
8888
} finally {
8989
try {
9090
if (rs != null) {
9191
rs.close();
9292
}
9393
} catch (SQLException ex) {
94-
logger.error("Failed to close rs", ex);
94+
LOGGER.error("Failed to close rs", ex);
9595
}
9696
try {
9797
if (pstmt != null) {
9898
pstmt.close();
9999
}
100100
} catch (SQLException ex) {
101-
logger.error("Failed to close pstmt", ex);
101+
LOGGER.error("Failed to close pstmt", ex);
102102
}
103103
try {
104104
if (con != null) {
105105
con.close();
106106
}
107107
} catch (SQLException ex) {
108-
logger.error("Failed to close con", ex);
108+
LOGGER.error("Failed to close con", ex);
109109
}
110110
}
111111

‎Ch05_HSTS/src/main/java/de/dominikschadow/webappsecurity/filter/HSTSFilter.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,17 @@
3030
* @author Dominik Schadow
3131
*/
3232
public class HSTSFilter implements Filter {
33-
private Logger logger = LoggerFactory.getLogger(getClass());
33+
private static final Logger LOGGER = LoggerFactory.getLogger(HSTSFilter.class);
3434

3535
@Override
3636
public void init(FilterConfig filterConfig) throws ServletException {
37-
logger.info("HSTSFilter init");
37+
LOGGER.info("HSTSFilter init");
3838
}
3939

4040
@Override
4141
public void doFilter(ServletRequest req, ServletResponse res, FilterChain chain) throws IOException, ServletException {
4242
((HttpServletResponse) res).setHeader("Strict-Transport-Security", "max-age=12960000; includeSubdomains");
43-
logger.info("Added Strict-Transport-Security header to response");
43+
LOGGER.info("Added Strict-Transport-Security header to response");
4444

4545
chain.doFilter(req, res);
4646
}

‎Ch05_HSTS/src/main/java/de/dominikschadow/webappsecurity/servlets/LoginServlet.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@
3636
*/
3737
@WebServlet(name = "LoginServlet", urlPatterns = {"/LoginServlet"})
3838
public class LoginServlet extends HttpServlet {
39-
private Logger logger = LoggerFactory.getLogger(getClass());
39+
private static final Logger LOGGER = LoggerFactory.getLogger(LoginServlet.class);
4040
private static final long serialVersionUID = 1L;
4141

4242
/**
4343
* @see javax.servlet.http.HttpServlet#doPost(javax.servlet.http.HttpServletRequest request, javax.servlet.http.HttpServletResponse response)
4444
*/
4545
protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException {
4646
String name = request.getParameter("name");
47-
logger.info("Received " + name + " as POST parameter");
47+
LOGGER.info("Received " + name + " as POST parameter");
4848

4949
// invalidate the current session
5050
request.getSession().invalidate();
@@ -63,7 +63,7 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
6363
out.println("</body>");
6464
out.println("</html>");
6565
} catch (IOException ex) {
66-
logger.error(ex.getMessage(), ex);
66+
LOGGER.error(ex.getMessage(), ex);
6767
}
6868
}
6969
}

‎Ch05_SessionFixation/src/main/java/de/dominikschadow/webappsecurity/servlets/LoginServlet.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@
3636
*/
3737
@WebServlet(name = "LoginServlet", urlPatterns = {"/LoginServlet"})
3838
public class LoginServlet extends HttpServlet {
39-
private Logger logger = LoggerFactory.getLogger(getClass());
39+
private static final Logger LOGGER = LoggerFactory.getLogger(LoginServlet.class);
4040
private static final long serialVersionUID = 1L;
4141

4242
/**
4343
* @see javax.servlet.http.HttpServlet#doPost(javax.servlet.http.HttpServletRequest request, javax.servlet.http.HttpServletResponse response)
4444
*/
4545
protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException {
4646
String name = request.getParameter("name");
47-
logger.info("Received " + name + " as POST parameter");
47+
LOGGER.info("Received " + name + " as POST parameter");
4848

4949
// invalidate the current session
5050
request.getSession().invalidate();
@@ -63,7 +63,7 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
6363
out.println("</body>");
6464
out.println("</html>");
6565
} catch (IOException ex) {
66-
logger.error(ex.getMessage(), ex);
66+
LOGGER.error(ex.getMessage(), ex);
6767
}
6868
}
6969
}

‎Ch06_SQLInjection/src/main/java/de/dominikschadow/webappsecurity/servlets/HQLServlet.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
*/
4949
@WebServlet(name = "HQLServlet", urlPatterns = {"/HQLServlet"})
5050
public class HQLServlet extends HttpServlet {
51-
private Logger logger = LoggerFactory.getLogger(getClass());
51+
private static final Logger LOGGER = LoggerFactory.getLogger(HQLServlet.class);
5252
private static final long serialVersionUID = 1L;
5353
private SessionFactory sessionFactory;
5454

@@ -72,7 +72,7 @@ public void destroy() {
7272
*/
7373
protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException {
7474
String name = request.getParameter("name");
75-
logger.info("Received " + name + " as POST parameter");
75+
LOGGER.info("Received " + name + " as POST parameter");
7676

7777
Session session = sessionFactory.openSession();
7878
Query query = session.createQuery("FROM Customer WHERE name = :name ORDER BY CUST_ID");
@@ -110,7 +110,7 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
110110
out.println("</body>");
111111
out.println("</html>");
112112
} catch (IOException ex) {
113-
logger.error(ex.getMessage(), ex);
113+
LOGGER.error(ex.getMessage(), ex);
114114
}
115115
}
116116
}

‎Ch06_SQLInjection/src/main/java/de/dominikschadow/webappsecurity/servlets/PreparedStatementServlet.java‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
*/
4545
@WebServlet(name = "PreparedStatementServlet", urlPatterns = {"/PreparedStatementServlet"})
4646
public class PreparedStatementServlet extends HttpServlet {
47-
private Logger logger = LoggerFactory.getLogger(getClass());
47+
private static final Logger LOGGER = LoggerFactory.getLogger(PreparedStatementServlet.class);
4848
private static final long serialVersionUID = 1L;
4949
private Connection con = null;
5050

@@ -54,7 +54,7 @@ public void init() {
5454
Class.forName("org.hsqldb.jdbcDriver");
5555
con = DriverManager.getConnection("jdbc:hsqldb:res:/customerDB; shutdown=true", "sa", "");
5656
} catch (ClassNotFoundException | SQLException ex) {
57-
logger.error(ex.getMessage(), ex);
57+
LOGGER.error(ex.getMessage(), ex);
5858
}
5959
}
6060

@@ -65,7 +65,7 @@ public void destroy() {
6565
con.close();
6666
}
6767
} catch (SQLException ex) {
68-
logger.error(ex.getMessage(), ex);
68+
LOGGER.error(ex.getMessage(), ex);
6969
}
7070
}
7171

@@ -74,7 +74,7 @@ public void destroy() {
7474
*/
7575
protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException {
7676
String name = request.getParameter("name");
77-
logger.info("Received " + name + " as POST parameter");
77+
LOGGER.info("Received " + name + " as POST parameter");
7878

7979
String query = "SELECT * FROM customer WHERE name = ? ORDER BY CUST_ID";
8080
List<Customer> customers = new ArrayList<>();
@@ -96,21 +96,21 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
9696
customers.add(customer);
9797
}
9898
} catch (SQLException ex) {
99-
logger.error(ex.getMessage(), ex);
99+
LOGGER.error(ex.getMessage(), ex);
100100
} finally {
101101
try {
102102
if (rs != null) {
103103
rs.close();
104104
}
105105
} catch (SQLException ex) {
106-
logger.error(ex.getMessage(), ex);
106+
LOGGER.error(ex.getMessage(), ex);
107107
}
108108
try {
109109
if (stmt != null) {
110110
stmt.close();
111111
}
112112
} catch (SQLException ex) {
113-
logger.error(ex.getMessage(), ex);
113+
LOGGER.error(ex.getMessage(), ex);
114114
}
115115
}
116116

@@ -144,7 +144,7 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
144144
out.println("</body>");
145145
out.println("</html>");
146146
} catch (IOException ex) {
147-
logger.error(ex.getMessage(), ex);
147+
LOGGER.error(ex.getMessage(), ex);
148148
}
149149
}
150150
}

0 commit comments

Comments
 (0)