Fix equality and hash for dns records with the unique bit#969
Merged
Conversation
- These records should have the same hash and equality since the unique bit is not considered when adding or removing the records from the cache
bdraco
force-pushed
the
class_dupe_unique
branch
from
6a8ff7f to
9093bda
Compare
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2456 2456
Branches 403 403
=========================================
Hits 2456 2456
Continue to review full report at Codecov.
|
bdraco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the unique bit is not considered when adding or removing
the records from the cache