Skip to content

Add coverage for sending answers removes future queued answers#961

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:explict_coverage_remove_on_send
Aug 15, 2021
Merged

Add coverage for sending answers removes future queued answers#961
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:explict_coverage_remove_on_send

Conversation

@bdraco

@bdraco bdraco commented Aug 15, 2021

Copy link
Copy Markdown
Member
  • If we send an answer that is queued to be sent out in the future
    we should remove it from the queue as the question has already
    been answered and we do not want to generate additional traffic.

@bdraco bdraco changed the title Add explict test coverage to ensure sending answers removes any future scheduled answers from the queue Add coverage for sending answers removing any future queued scheduled answers Aug 15, 2021
@bdraco bdraco changed the title Add coverage for sending answers removing any future queued scheduled answers Add coverage for sending answers removes future queued scheduled answers Aug 15, 2021
@bdraco bdraco changed the title Add coverage for sending answers removes future queued scheduled answers Add coverage for sending answers removes future queued answers Aug 15, 2021
@bdraco bdraco force-pushed the explict_coverage_remove_on_send branch from 4ec916f to ef0a529 Compare August 15, 2021 15:04
@bdraco bdraco force-pushed the explict_coverage_remove_on_send branch from ef0a529 to ed52266 Compare August 15, 2021 15:04
@codecov-commenter

codecov-commenter commented Aug 15, 2021

Copy link
Copy Markdown

Codecov Report

Merging #961 (ed52266) into master (7b125a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #961   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2441      2443    +2     
  Branches       402       402           
=========================================
+ Hits          2441      2443    +2     
Impacted Files Coverage Δ
zeroconf/_handlers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b125a1...ed52266. Read the comment docs.

@bdraco bdraco merged commit 2d1b832 into python-zeroconf:master Aug 15, 2021
@bdraco bdraco deleted the explict_coverage_remove_on_send branch August 15, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants