Cache DNS record and question hashes#960
Merged
Merged
Conversation
bdraco
force-pushed
the
cache_hash
branch
4 times, most recently
from
167816d to
4b79383
Compare
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
===========================================
- Coverage 100.00% 99.87% -0.13%
===========================================
Files 22 22
Lines 2436 2446 +10
Branches 401 401
===========================================
+ Hits 2436 2443 +7
- Misses 0 2 +2
- Partials 0 1 +1
Continue to review full report at Codecov.
|
- The hash was being recalculated every time the object was being used in a set or dict. Since the hashes are effectively immutable, we only calculate them once now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was being used in a set or dict. Since the hashes are
effectively immutable, we only calculate them once now.
Closes #959