Ensure zeroconf can be loaded when the system disables IPv6#933
Conversation
related to #234 The current error on 0.32.1 up to 0.33.2: >>> import zeroconf Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python3.9/site-packages/zeroconf/__init__.py", line 25, in <module> from ._cache import DNSCache # noqa # import needed for backwards compat File "/usr/lib/python3.9/site-packages/zeroconf/_cache.py", line 26, in <module> from ._dns import ( File "/usr/lib/python3.9/site-packages/zeroconf/_dns.py", line 28, in <module> from ._utils.net import _is_v6_address File "/usr/lib/python3.9/site-packages/zeroconf/_utils/net.py", line 34, in <module> from ..const import _IPPROTO_IPV6, _MDNS_ADDR6_BYTES, _MDNS_ADDR_BYTES, _MDNS_PORT ImportError: cannot import name '_MDNS_ADDR6_BYTES' from 'zeroconf.const' (/usr/lib/python3.9/site-packages/zeroconf/const.py)
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2315 2358 +43
Branches 383 388 +5
=========================================
+ Hits 2315 2358 +43
Continue to review full report at Codecov.
|
There's no point in faking result in inet_pton(AF_INET6) if we're not using it. Co-authored-by: J. Nick Koston <nick@koston.org>
|
Oh :/
|
bdraco
left a comment
bdraco
left a comment
There was a problem hiding this comment.
This should be good to merge once the test coverage is added
The results were used only once and I didn't find any way to mock their results.
|
Unfortunately I did not find any way to mock |
|
Do you need a new release ? |
3 participants
related to #234
The current error on 0.32.1 up to 0.33.2: