Handle duplicate goodbye answers in the same packet#928
Merged
Conversation
Closed
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2315 2315
Branches 383 383
=========================================
Hits 2315 2315
Continue to review full report at Codecov.
|
bdraco
force-pushed
the
dupe_records_in_packet
branch
from
af12a2f to
fb529bc
Compare
bdraco
changed the title
systemcrash
added a commit
to openairplay/airplay2-receiver
that referenced
this pull request
Jul 28, 2021
Bump zeroconf to 0.33.2 after upstream bugfix (for shutdown traceback). python-zeroconf/python-zeroconf#926 python-zeroconf/python-zeroconf#928
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves an exception being thrown when we tried to remove the known answer
from the cache when the second goodbye answer in the same packet was processed
We previously swallowed all exceptions on cache removal so this was not
visible until 0.32.x which removed the broad exception catch
Fixes #926