Skip to content

Remove some pylint workarounds #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Jul 22, 2021
Merged

Remove some pylint workarounds #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions zeroconf/_dns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@


if TYPE_CHECKING:
# https://github.com/PyCQA/pylint/issues/3525
from ._protocol import DNSIncoming, DNSOutgoing # pylint: disable=cyclic-import
from ._protocol import DNSIncoming, DNSOutgoing


@enum.unique
Expand Down
3 changes: 1 addition & 2 deletions zeroconf/_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@
)

if TYPE_CHECKING:
# https://github.com/PyCQA/pylint/issues/3525
from ._core import Zeroconf # pylint: disable=cyclic-import
from ._core import Zeroconf


_AnswerWithAdditionalsType = Dict[DNSRecord, Set[DNSRecord]]
Expand Down
2 changes: 1 addition & 1 deletion zeroconf/_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import sys
from typing import Any, Dict, Union, cast

log = logging.getLogger(__name__.split('.')[0])
log = logging.getLogger(__name__.split('.', maxsplit=1)[0])
log.addHandler(logging.NullHandler())


Expand Down
3 changes: 1 addition & 2 deletions zeroconf/_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@


if TYPE_CHECKING:
# https://github.com/PyCQA/pylint/issues/3525
from ._cache import DNSCache # pylint: disable=cyclic-import
from ._cache import DNSCache


class DNSMessage:
Expand Down
3 changes: 1 addition & 2 deletions zeroconf/_services/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@


if TYPE_CHECKING:
# https://github.com/PyCQA/pylint/issues/3525
from .._core import Zeroconf # pylint: disable=cyclic-import
from .._core import Zeroconf


@enum.unique
Expand Down
3 changes: 1 addition & 2 deletions zeroconf/_services/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@
}

if TYPE_CHECKING:
# https://github.com/PyCQA/pylint/issues/3525
from .._core import Zeroconf # pylint: disable=cyclic-import
from .._core import Zeroconf


_QuestionWithKnownAnswers = Dict[DNSQuestion, Set[DNSPointer]]
Expand Down
3 changes: 1 addition & 2 deletions zeroconf/_services/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@


if TYPE_CHECKING:
# https://github.com/PyCQA/pylint/issues/3525
from .._core import Zeroconf # pylint: disable=cyclic-import
from .._core import Zeroconf


def instance_name_from_service_info(info: "ServiceInfo") -> str:
Expand Down
3 changes: 1 addition & 2 deletions zeroconf/_updates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@


if TYPE_CHECKING:
# https://github.com/PyCQA/pylint/issues/3525
from ._core import Zeroconf # pylint: disable=cyclic-import
from ._core import Zeroconf


class RecordUpdate(NamedTuple):
Expand Down
2 changes: 1 addition & 1 deletion zeroconf/_utils/net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def set_mdns_port_socket_options_for_ip_version(
s.setsockopt(_IPPROTO_IPV6, socket.IPV6_MULTICAST_LOOP, True)


def new_socket( # pylint: disable=too-many-branches
def new_socket(
bind_addr: Union[Tuple[str], Tuple[str, int, int]],
port: int = _MDNS_PORT,
ip_version: IPVersion = IPVersion.V4Only,
Expand Down