Skip to content

Fix deadlock when event loop is shutdown during service registration#869

Merged
bdraco merged 4 commits into
python-zeroconf:masterfrom
bdraco:handle_eventloop_shutdown
Jun 28, 2021
Merged

Fix deadlock when event loop is shutdown during service registration#869
bdraco merged 4 commits into
python-zeroconf:masterfrom
bdraco:handle_eventloop_shutdown

Conversation

@bdraco

@bdraco bdraco commented Jun 28, 2021

Copy link
Copy Markdown
Member
  • Add timeouts in all places where the event loop might get shutdown from under us.

@codecov-commenter

codecov-commenter commented Jun 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #869 (ec3f0c0) into master (22ff6b5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
+ Coverage   99.57%   99.61%   +0.04%     
==========================================
  Files          22       22              
  Lines        2330     2335       +5     
  Branches      391      391              
==========================================
+ Hits         2320     2326       +6     
  Misses          5        5              
+ Partials        5        4       -1     
Impacted Files Coverage Δ
zeroconf/_core.py 100.00% <100.00%> (ø)
zeroconf/_services/info.py 100.00% <100.00%> (ø)
zeroconf/_utils/aio.py 100.00% <100.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ff6b5...ec3f0c0. Read the comment docs.

@bdraco bdraco merged commit 4ed9036 into python-zeroconf:master Jun 28, 2021
@bdraco bdraco deleted the handle_eventloop_shutdown branch June 28, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants