Switch ServiceBrowser query scheduling to use call_later instead of a loop#849
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
==========================================
- Coverage 98.63% 98.63% -0.01%
==========================================
Files 22 22
Lines 2349 2339 -10
Branches 398 398
==========================================
- Hits 2317 2307 -10
Misses 21 21
Partials 11 11
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies scheduling as there is no more need to sleep in a loop as
we now schedule future callbacks with call_later
Simplifies cancelation as there is no more coroutine to cancel, only a timer handle
We no longer have to handle the canceled error and cleaning up the awaitable
Solves the infrequent test failures in test_backoff and test_integration