Codecov Report

Merging #829 (4f6f9d4) into master (8c9d1d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          22       22           
  Lines        2339     2339           
  Branches      398      398           
=======================================
  Hits         2307     2307           
  Misses         21       21           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9d1d8...4f6f9d4. Read the comment docs.

Of course it doesn't break when I want it to 🙄

Looks like the other one is failing due to the fact the test floods the network interface and the duplicate packet suppression is kicking in. We can patch that out to fix it

Or use the inject helper instead

We should limit duplicate packet protection to 1s Break it out into a function and add a test We can then patch it out in the integration test in case that's the issue

Looks like sometimes it fails because the loop unblocks before we are waiting for the event.

Seems more likely on PyPy.

Likely we need to patch the code instead of inject the time change to make it reliable.

This was fixed in #849