Skip to content

Ensure we handle threadsafe shutdown under PyPy with multiple event loops#800

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:pypy_threadsafe_shutdown
Jun 21, 2021
Merged

Ensure we handle threadsafe shutdown under PyPy with multiple event loops#800
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:pypy_threadsafe_shutdown

Conversation

@bdraco

@bdraco bdraco commented Jun 21, 2021

Copy link
Copy Markdown
Member

Fixes #799

@codecov-commenter

codecov-commenter commented Jun 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #800 (f02d944) into master (9961dce) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
- Coverage   98.72%   98.67%   -0.05%     
==========================================
  Files          22       22              
  Lines        2268     2271       +3     
  Branches      388      389       +1     
==========================================
+ Hits         2239     2241       +2     
  Misses         18       18              
- Partials       11       12       +1     
Impacted Files Coverage Δ
zeroconf/_utils/aio.py 96.00% <100.00%> (-1.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9961dce...f02d944. Read the comment docs.

@bdraco bdraco force-pushed the pypy_threadsafe_shutdown branch from 95668a6 to f02d944 Compare June 21, 2021 19:45
@bdraco bdraco merged commit bbc9124 into python-zeroconf:master Jun 21, 2021
@bdraco bdraco deleted the pypy_threadsafe_shutdown branch June 21, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shutdown is not threadsafe on PyPy

2 participants