Skip to content

Ensure outgoing ServiceBrowser questions are seen by the question history #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Jun 21, 2021
Merged

Ensure outgoing ServiceBrowser questions are seen by the question history #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/services/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,4 +1045,15 @@ async def test_generate_service_query_suppress_duplicate_questions():
# We do not suppress QU queries ever
outs = _services_browser.generate_service_query(zc, now, [name], multicast=False)
assert outs

zc.question_history.async_expire(now + 1000)
# No suppression after clearing the history
outs = _services_browser.generate_service_query(zc, now, [name], multicast=True)
assert outs

# The previous query we just sent is still remembered and
# the next one is suppressed
outs = _services_browser.generate_service_query(zc, now, [name], multicast=True)
assert not outs

await aiozc.async_close()
1 change: 1 addition & 0 deletions zeroconf/_services/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ def generate_service_query(
log.debug("Asking %s was suppressed by the question history", question)
continue
questions_with_known_answers[question] = known_answers
zc.question_history.add_question_at_time(question, now, cast(Set[DNSRecord], known_answers))

return _group_ptr_queries_with_known_answers(now, multicast, questions_with_known_answers)

Expand Down