Skip to content

Ensure outgoing ServiceBrowser questions are seen by the question history - #790

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:dupe_question_before_sending
Jun 21, 2021
Merged

Ensure outgoing ServiceBrowser questions are seen by the question history#790
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:dupe_question_before_sending

Conversation

@bdraco

@bdraco bdraco commented Jun 21, 2021

Copy link
Copy Markdown
Member
  • Ensures duplicate question suppression between ServiceBrowsers that
    are running in the same zeroconf instances if they become
    synchronized (which is likely due to like TTL expire time)

Fixes #789

…tory

- Ensures duplicate question suppression between ServiceBrowsers that
  are running in the same zeroconf instances if they become
  synchronized
@codecov-commenter

codecov-commenter commented Jun 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #790 (6224e0f) into master (5d23628) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          21       21           
  Lines        2260     2261    +1     
  Branches      386      386           
=======================================
+ Hits         2231     2232    +1     
  Misses         18       18           
  Partials       11       11           
Impacted Files Coverage Δ
zeroconf/_services/browser.py 98.14% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d23628...6224e0f. Read the comment docs.

@bdraco
bdraco merged commit ecad4e8 into python-zeroconf:master Jun 21, 2021
@bdraco
bdraco deleted the dupe_question_before_sending branch June 21, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If ServiceBrowsers get synchronized duplicate question suppression doesn't see the question soon enough

2 participants