Implement duplicate question supression by bdraco · Pull Request #770 · python-zeroconf/python-zeroconf

bdraco · 2021-06-20T17:50:18Z

https://datatracker.ietf.org/doc/html/rfc6762#section-7.3

7.3. Duplicate Question Suppression

If a host is planning to transmit (or retransmit) a query, and it
sees another host on the network send a query containing the same
"QM" question, and the Known-Answer Section of that query does not
contain any records that this host would not also put in its own
Known-Answer Section, then this host SHOULD treat its own query as
having been sent. When multiple queriers on the network are querying
for the same resource records, there is no need for them to all be
repeatedly asking the same question.

Fixes #721

bdraco · 2021-06-20T17:54:11Z

Need to make sure we do not record QU questions as we can only suppress QM questions

codecov-commenter · 2021-06-20T17:57:54Z

Codecov Report

Merging #770 (5942e91) into master (b5d54e4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
- Coverage   98.41%   98.39%   -0.02%     
==========================================
  Files          20       21       +1     
  Lines        2204     2240      +36     
  Branches      375      380       +5     
==========================================
+ Hits         2169     2204      +35     
  Misses         22       22              
- Partials       13       14       +1

Impacted Files	Coverage Δ
zeroconf/_core.py	`97.88% <100.00%> (+0.01%)`	⬆️
zeroconf/_dns.py	`100.00% <100.00%> (ø)`
zeroconf/_handlers.py	`100.00% <100.00%> (ø)`
zeroconf/_history.py	`100.00% <100.00%> (ø)`
zeroconf/_services/browser.py	`98.09% <100.00%> (+0.04%)`	⬆️
zeroconf/const.py	`97.46% <100.00%> (+0.03%)`	⬆️
zeroconf/_utils/aio.py	`95.74% <0.00%> (-2.13%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d54e4...5942e91. Read the comment docs.

…n_suppression

…uestion_suppression

bdraco · 2021-06-20T21:02:46Z

Verified its only suppressing what it should

2021-06-20 18:44:24 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 18:44:24 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 18:47:24 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 18:47:24 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 18:54:54 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 18:54:54 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:02:24 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:02:24 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:06:54 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:06:54 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:11:24 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:11:24 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:15:04 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:15:04 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:18:04 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:18:04 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:22:34 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:22:34 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:30:04 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:30:04 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:40:34 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:40:34 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:52:44 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:52:44 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:55:44 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:55:44 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:58:44 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 19:58:44 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:05:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:05:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:07:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:07:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:08:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:08:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:10:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:10:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:11:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:11:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:17:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:17:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:19:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:19:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:22:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:22:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:23:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:23:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:25:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:25:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:26:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:26:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:34:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:34:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:40:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:40:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:44:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:44:30 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:52:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 20:52:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 21:01:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history
2021-06-20 21:01:00 DEBUG (MainThread) [zeroconf] Asking ptr[question,QM,in,_googlecast._tcp.local.] was suppressed by the question history

…n_suppression

Fixes deadlock in ``` zeroconf/_services/browser.py:442: in cancel asyncio.run_coroutine_threadsafe(self._async_cancel_browser(), self.zc.loop).result() ```

…r_start

…ession

…n_suppression

bdraco added 2 commits June 20, 2021 07:43

Implement duplicate question supression

473f25e

disable question history supression in backoff test

5b338e9

bdraco added the traffic-reduction label Jun 20, 2021

bdraco marked this pull request as draft June 20, 2021 17:50

bdraco commented Jun 20, 2021

View reviewed changes

Comment thread zeroconf/_core.py Outdated

debug log

999e189

QM questions only

bc6a745

bdraco added 13 commits June 20, 2021 08:06

QM questions only

bec2ac8

QM questions only

4598bdb

QM questions only

0c4744b

Merge remote-tracking branch 'upstream/master' into duplicate_questio…

e67b4cc

…n_suppression

replicate

908bdea

imports

0600136

comments

87aa364

comments

d1197f4

multicast only

946cf90

Implement accidental synchronization protection (RFC2762 section 5.2)

523438b

cover

15d824a

typing

afe7530

Merge branch 'avoid_accidental_service_browser_sync' into duplicate_q…

748a33c

…uestion_suppression

bdraco added 7 commits June 20, 2021 11:13

Add unit tests for history

e86687a

test that the reaper expires the question history

da68170

test that the question history gets populated

7efa561

Merge remote-tracking branch 'upstream/master' into duplicate_questio…

062cb80

…n_suppression

qu question test

7f8fe88

Fix deadlock on ServiceBrowser shutdown with PyPy

16aa403

Fixes deadlock in ``` zeroconf/_services/browser.py:442: in cancel asyncio.run_coroutine_threadsafe(self._async_cancel_browser(), self.zc.loop).result() ```

test query generator

11718b5

bdraco added 3 commits June 20, 2021 12:05

remove unused

56c81a1

Merge remote-tracking branch 'upstream/master' into threadsafe_browse…

0e3ce44

…r_start

Merge branch 'threadsafe_browser_start' into duplicate_question_suppr…

369f9dc

…ession

bdraco marked this pull request as ready for review June 20, 2021 22:34

Merge remote-tracking branch 'upstream/master' into duplicate_questio…

5942e91

…n_suppression

bdraco merged commit c0f4f48 into python-zeroconf:master Jun 20, 2021

bdraco deleted the duplicate_question_suppression branch June 20, 2021 22:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement duplicate question supression#770

Implement duplicate question supression#770
bdraco merged 28 commits into
python-zeroconf:masterfrom
bdraco:duplicate_question_suppression

bdraco commented Jun 20, 2021 •

edited

Loading

Uh oh!

Uh oh!

bdraco commented Jun 20, 2021

Uh oh!

codecov-commenter commented Jun 20, 2021 •

edited

Loading

Uh oh!

bdraco commented Jun 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bdraco commented Jun 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bdraco commented Jun 20, 2021

Uh oh!

codecov-commenter commented Jun 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bdraco commented Jun 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bdraco commented Jun 20, 2021 •

edited

Loading

codecov-commenter commented Jun 20, 2021 •

edited

Loading