Break test_lots_of_names into two tests#764
Merged
Merged
Conversation
- This was testing two things: name changes and log handling - Now test_verify_name_change_with_lots_of_names and test_large_packet_exception_log_handling This test was failing occasionally on pypy3 mac os only and the CI did not give enough to understand what was going wrong. Next time it fails we will get a better idea where.
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
==========================================
- Coverage 98.68% 98.36% -0.32%
==========================================
Files 20 20
Lines 2198 2198
Branches 375 375
==========================================
- Hits 2169 2162 -7
- Misses 18 22 +4
- Partials 11 14 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was testing two things: name changes and log handling
Now test_verify_name_change_with_lots_of_names and
test_large_packet_exception_log_handling
This test was failing occasionally on pypy3 mac os only
and the CI did not give enough to understand what was going
wrong. Next time it fails we will get a better idea where.