Fix test_lots_of_names overflowing the incoming buffer#763
Merged
Conversation
- This test generated many hosts and tries to send them and backoff to ensure the incoming buffer does not get full and incoming starts getting dropped. That did not already work. Switch to using our _inject_response helper to avoid the spurious failure since we are not testing the network stack
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 20 20
Lines 2198 2198
Branches 375 375
=======================================
Hits 2168 2168
Misses 18 18
Partials 12 12 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backoff to ensure the incoming buffer does not get full and
incoming starts getting dropped. That did not already work.
Switch to using our _inject_response helper to avoid the
spurious failure since we are not testing the network stack