Fix race condition in ServiceBrowser test_integration#762
Merged
Conversation
- The event was being cleared in the wrong thread which meant if the test was fast enough it would not be seen the second time and give a spurious failure
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
==========================================
+ Coverage 98.63% 98.68% +0.04%
==========================================
Files 20 20
Lines 2198 2198
Branches 375 375
==========================================
+ Hits 2168 2169 +1
Misses 18 18
+ Partials 12 11 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meant if the test was fast enough it would not be seen
the second time and give a spurious failure