Skip to content

Remove sleeps from services types test #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Jun 16, 2021
Merged

Remove sleeps from services types test #688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions tests/services/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@ def test_integration_with_listener(self):
"ash-2.local.",
addresses=[socket.inet_aton("10.0.1.2")],
)
zeroconf_registrar.register_service(info)
# Ensure we do not clear the cache until after the last broadcast is processed
time.sleep(0.2)
_clear_cache(zeroconf_registrar)
zeroconf_registrar.registry.add(info)
try:
service_types = ZeroconfServiceTypes.find(interfaces=['127.0.0.1'], timeout=0.5)
assert type_ in service_types
Expand Down Expand Up @@ -70,10 +67,7 @@ def test_integration_with_listener_v6_records(self):
"ash-2.local.",
addresses=[socket.inet_pton(socket.AF_INET6, addr)],
)
zeroconf_registrar.register_service(info)
# Ensure we do not clear the cache until after the last broadcast is processed
time.sleep(0.2)
_clear_cache(zeroconf_registrar)
zeroconf_registrar.registry.add(info)
try:
service_types = ZeroconfServiceTypes.find(interfaces=['127.0.0.1'], timeout=0.5)
assert type_ in service_types
Expand Down Expand Up @@ -104,10 +98,7 @@ def test_integration_with_listener_ipv6(self):
"ash-2.local.",
addresses=[socket.inet_aton("10.0.1.2")],
)
zeroconf_registrar.register_service(info)
# Ensure we do not clear the cache until after the last broadcast is processed
time.sleep(0.2)
_clear_cache(zeroconf_registrar)
zeroconf_registrar.registry.add(info)
try:
service_types = ZeroconfServiceTypes.find(ip_version=r.IPVersion.V6Only, timeout=0.5)
assert type_ in service_types
Expand Down Expand Up @@ -138,10 +129,7 @@ def test_integration_with_subtype_and_listener(self):
"ash-2.local.",
addresses=[socket.inet_aton("10.0.1.2")],
)
zeroconf_registrar.register_service(info)
# Ensure we do not clear the cache until after the last broadcast is processed
time.sleep(0.2)
_clear_cache(zeroconf_registrar)
zeroconf_registrar.registry.add(info)
try:
service_types = ZeroconfServiceTypes.find(interfaces=['127.0.0.1'], timeout=0.5)
assert discovery_type in service_types
Expand Down