Allow unregistering a service multiple times - #679
Merged
Conversation
- In production unregister_service and unregister_all_services may happen at the same time during shutdown. We want to treat this as non-fatal since its expected to happen and it is unlikely that the callers know about each other.
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 97.80% 97.80%
=======================================
Files 17 17
Lines 2093 2095 +2
Branches 363 364 +1
=======================================
+ Hits 2047 2049 +2
Misses 27 27
Partials 19 19
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
may happen at the same time during shutdown. We want to treat
this as non-fatal since its expected to happen and it is unlikely
that the callers know about each other.
Fixes #675