Skip to content

Add missing coverage for ServiceInfo address changes #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Jun 16, 2021
Merged

Add missing coverage for ServiceInfo address changes #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions tests/test_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,3 +1299,36 @@ class MyPartialListener(r.ServiceListener):
)

zc.close()


def test_serviceinfo_address_updates():
"""Verify adding/removing/setting addresses on ServiceInfo."""
type_ = "_homeassistant._tcp.local."
name = "MyTestHome"

# Verify addresses and parsed_addresses are mutually exclusive
with pytest.raises(TypeError):
info_service = ServiceInfo(
type_,
'%s.%s' % (name, type_),
80,
0,
0,
{'path': '/~paulsm/'},
"ash-2.local.",
addresses=[socket.inet_aton("10.0.1.2")],
parsed_addresses=["10.0.1.2"],
)

info_service = ServiceInfo(
type_,
'%s.%s' % (name, type_),
80,
0,
0,
{'path': '/~paulsm/'},
"ash-2.local.",
addresses=[socket.inet_aton("10.0.1.2")],
)
info_service.addresses = [socket.inet_aton("10.0.1.3")]
assert info_service.addresses == [socket.inet_aton("10.0.1.3")]