Ensure the ServiceInfo.key gets updated when the name is changed externally#645
Merged
Merged
Conversation
…rnally When registering a service, allow_name change can mutate the ServiceInfo.name
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
+ Coverage 96.52% 96.54% +0.01%
==========================================
Files 17 17
Lines 2046 2053 +7
Branches 353 353
==========================================
+ Hits 1975 1982 +7
Misses 40 40
Partials 31 31
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When registering a service, allow_name change can mutate the ServiceInfo.name