Avoid including additionals when the answer is suppressed by known-answer supression#614
Merged
bdraco merged 1 commit intoJun 14, 2021
Conversation
…swer supression - If the PTR or SRV record was suppressed we should not include the additionals per https://tools.ietf.org/html/rfc6763#section-12.1
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
+ Coverage 95.55% 95.71% +0.16%
==========================================
Files 18 18
Lines 1956 1961 +5
Branches 345 347 +2
==========================================
+ Hits 1869 1877 +8
+ Misses 46 45 -1
+ Partials 41 39 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include the additionals per
https://tools.ietf.org/html/rfc6763#section-12.1
Fixes #613
Broken out from #603