Skip to content

Query Handler fixes#603

Closed
bdraco wants to merge 50 commits into
python-zeroconf:masterfrom
bdraco:query_handlers_fixes
Closed

Query Handler fixes#603
bdraco wants to merge 50 commits into
python-zeroconf:masterfrom
bdraco:query_handlers_fixes

Conversation

@bdraco

@bdraco bdraco commented Jun 14, 2021

Copy link
Copy Markdown
Member

Fixes #395 fixed in #619

Fixes #595 fixed in #616

Fixes #500 implemented in #621

Fixes #464 fixed in #618

Fixes #604 fixed in #617

Fixes #613 fixed in #617

@codecov-commenter

codecov-commenter commented Jun 14, 2021

Copy link
Copy Markdown

Codecov Report

Merging #603 (4d1df72) into master (1f36754) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
- Coverage   95.54%   95.28%   -0.26%     
==========================================
  Files          18       18              
  Lines        2021     2037      +16     
  Branches      354      359       +5     
==========================================
+ Hits         1931     1941      +10     
- Misses         48       55       +7     
+ Partials       42       41       -1     
Impacted Files Coverage Δ
zeroconf/_handlers.py 100.00% <100.00%> (ø)
zeroconf/const.py 97.29% <0.00%> (-2.71%) ⬇️
zeroconf/_utils/net.py 85.94% <0.00%> (-2.17%) ⬇️
zeroconf/_core.py 89.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f36754...4d1df72. Read the comment docs.

@bdraco

bdraco commented Jun 14, 2021

Copy link
Copy Markdown
Member Author

The general design works and is fast. This needs to be broken down into 4-5 PRs though

@bdraco

bdraco commented Jun 14, 2021

Copy link
Copy Markdown
Member Author

Before this change, mdns logging was just streaming off the screen. Now the network can go a few seconds without a query or response

@bdraco

bdraco commented Jun 14, 2021

Copy link
Copy Markdown
Member Author

The largest source of excess traffic seems to be responses that should be suppressed with multi-packet known query suppression #499

Comment thread zeroconf/_handlers.py Outdated
@bdraco

bdraco commented Jun 14, 2021

Copy link
Copy Markdown
Member Author

Still needs coverage for a fully suppressed query where everything is a known answer

@bdraco bdraco mentioned this pull request Jun 14, 2021
@bdraco

bdraco commented Jun 15, 2021

Copy link
Copy Markdown
Member Author

All implemented in other PRs

@bdraco bdraco closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment