Skip to content

Add unicast property to DNSQuestion to determine if the QU bit is set#593

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:qu_bit
Jun 13, 2021
Merged

Add unicast property to DNSQuestion to determine if the QU bit is set#593
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:qu_bit

Conversation

@bdraco

@bdraco bdraco commented Jun 13, 2021

Copy link
Copy Markdown
Member

Needed to fix #500

@codecov-commenter

codecov-commenter commented Jun 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #593 (bb79801) into master (35e25fd) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
+ Coverage   95.13%   95.22%   +0.09%     
==========================================
  Files          18       18              
  Lines        1953     1948       -5     
  Branches      348      346       -2     
==========================================
- Hits         1858     1855       -3     
+ Misses         52       51       -1     
+ Partials       43       42       -1     
Impacted Files Coverage Δ
zeroconf/_dns.py 98.64% <100.00%> (-0.02%) ⬇️
zeroconf/_core.py 89.33% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e25fd...bb79801. Read the comment docs.

@bdraco bdraco merged commit d2d8262 into python-zeroconf:master Jun 13, 2021
@bdraco bdraco deleted the qu_bit branch June 13, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The query responder ignores the QU bit and multicasts the response regardless of the bit

2 participants