Skip to content

Set mypy follow_imports to skip as ignore is not a valid option#590

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:fix_mypy_error_ci
Jun 13, 2021
Merged

Set mypy follow_imports to skip as ignore is not a valid option#590
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:fix_mypy_error_ci

Conversation

@bdraco

@bdraco bdraco commented Jun 13, 2021

Copy link
Copy Markdown
Member

Fixes #589

@codecov-commenter

codecov-commenter commented Jun 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #590 (3a837d9) into master (ae6530a) will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
- Coverage   95.13%   94.77%   -0.36%     
==========================================
  Files          18       18              
  Lines        1954     1954              
  Branches      349      349              
==========================================
- Hits         1859     1852       -7     
- Misses         51       57       +6     
- Partials       44       45       +1     
Impacted Files Coverage Δ
zeroconf/_utils/net.py 88.10% <0.00%> (-2.17%) ⬇️
zeroconf/_core.py 88.33% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6530a...3a837d9. Read the comment docs.

@bdraco bdraco merged commit fd70ac1 into python-zeroconf:master Jun 13, 2021
@bdraco bdraco deleted the fix_mypy_error_ci branch June 13, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix mypy error during CI

2 participants