Skip to content

Move logger into zeroconf.logger#533

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:breakout_logger
Jun 12, 2021
Merged

Move logger into zeroconf.logger#533
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:breakout_logger

Conversation

@bdraco

@bdraco bdraco commented Jun 12, 2021

Copy link
Copy Markdown
Member

Supports #521

@bdraco bdraco mentioned this pull request Jun 12, 2021
11 tasks
@bdraco bdraco force-pushed the breakout_logger branch from 185c149 to 729b1c5 Compare June 12, 2021 21:32
@bdraco bdraco force-pushed the breakout_logger branch from 729b1c5 to 50e442d Compare June 12, 2021 21:32
@codecov-commenter

codecov-commenter commented Jun 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #533 (50e442d) into master (5100506) will increase coverage by 0.11%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   93.50%   93.62%   +0.11%     
==========================================
  Files           6        7       +1     
  Lines        1879     1882       +3     
  Branches      350      350              
==========================================
+ Hits         1757     1762       +5     
+ Misses         75       74       -1     
+ Partials       47       46       -1     
Impacted Files Coverage Δ
zeroconf/logger.py 70.37% <70.37%> (ø)
zeroconf/__init__.py 93.01% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5100506...50e442d. Read the comment docs.

@bdraco

bdraco commented Jun 12, 2021

Copy link
Copy Markdown
Member Author

Coverage is a bit light here. Should add more coverage before doing more breakouts

@bdraco bdraco merged commit e2e4eed into python-zeroconf:master Jun 12, 2021
@bdraco bdraco deleted the breakout_logger branch June 12, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants