Switch from using an asyncio.Event to asyncio.Condition for waiting#482
Merged
Merged
Conversation
- Using a asyncio.Condition permits fixing a race condition in processing handlers similar to the sync version in python-zeroconf#477
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 95.62% 95.96% +0.33%
==========================================
Files 4 4
Lines 3338 3369 +31
Branches 402 407 +5
==========================================
+ Hits 3192 3233 +41
+ Misses 89 80 -9
+ Partials 57 56 -1
Continue to review full report at Codecov.
|
bdraco
commented
Jun 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in processing handlers similar to the sync version in ServiceBrowser must recheck for handlers to call when holding condition #477
Fixes #479