AsyncServiceBrowser must recheck for handlers to call when holding condition#478
Closed
bdraco wants to merge 1 commit into
Closed
AsyncServiceBrowser must recheck for handlers to call when holding condition#478bdraco wants to merge 1 commit into
bdraco wants to merge 1 commit into
Conversation
bdraco
force-pushed
the
handlers_to_call_asb_race
branch
from
4d6f62d to
cdccef2
Compare
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 95.62% 95.88% +0.26%
==========================================
Files 4 4
Lines 3338 3381 +43
Branches 402 409 +7
==========================================
+ Hits 3192 3242 +50
+ Misses 89 83 -6
+ Partials 57 56 -1
Continue to review full report at Codecov.
|
bdraco
force-pushed
the
handlers_to_call_asb_race
branch
from
cdccef2 to
423bc12
Compare
Member
Author
|
Except |
bdraco
force-pushed
the
handlers_to_call_asb_race
branch
2 times, most recently
from
144a194 to
ecd6ff3
Compare
…ndition - There was a short race condition window where the AsyncServiceBrowser could add to _handlers_to_call in the Engine thread, have the condition notify_all called, but since the AsyncServiceBrowser was not yet holding the condition it would not know to stop waiting and process the handlers to call.
bdraco
force-pushed
the
handlers_to_call_asb_race
branch
from
ecd6ff3 to
66bf28f
Compare
Member
Author
|
...and the test failure is in the sync code that is fixed by #477 |
Member
Author
|
Its all working now, but I need to break this into two PRs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
could add to _handlers_to_call in the Engine thread, have the
condition notify_all called, but since the AsyncServiceBrowser was
not yet holding the condition it would not know to stop waiting
and process the handlers to call.
Fixes #476 for async, #477 is the fix for sync
Fixes #471