Skip to content

Clear cache between ServiceTypesQuery tests#466

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:clear_cache_between_tests
Jun 6, 2021
Merged

Clear cache between ServiceTypesQuery tests#466
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:clear_cache_between_tests

Conversation

@bdraco

@bdraco bdraco commented Jun 6, 2021

Copy link
Copy Markdown
Member
  • Ensures the test relies on the ZeroconfServiceTypes.find making
    the correct calls instead of the cache from the previous call

Breakout of #465

- Ensures the test relies on the ZeroconfServiceTypes.find making
  the correct calls instead of the cache from the previous call
@codecov-commenter

codecov-commenter commented Jun 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #466 (d4a483e) into master (c1ed987) will increase coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   95.22%   95.72%   +0.49%     
==========================================
  Files           4        4              
  Lines        3290     3296       +6     
  Branches      402      402              
==========================================
+ Hits         3133     3155      +22     
+ Misses         97       85      -12     
+ Partials       60       56       -4     
Impacted Files Coverage Δ
zeroconf/test.py 98.85% <100.00%> (+<0.01%) ⬆️
zeroconf/__init__.py 92.25% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ed987...d4a483e. Read the comment docs.

@bdraco bdraco merged commit c3365e1 into python-zeroconf:master Jun 6, 2021
@bdraco bdraco deleted the clear_cache_between_tests branch June 6, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants