Skip to content

Ensure PTR questions asked in uppercase are answered#465

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:answer_uppercase_ptr_questions
Jun 6, 2021
Merged

Ensure PTR questions asked in uppercase are answered#465
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:answer_uppercase_ptr_questions

Conversation

@bdraco

@bdraco bdraco commented Jun 6, 2021

Copy link
Copy Markdown
Member

Fixes #463

@bdraco bdraco force-pushed the answer_uppercase_ptr_questions branch from 8a54608 to d933724 Compare June 6, 2021 02:36
@codecov-commenter

codecov-commenter commented Jun 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #465 (a05de67) into master (c3365e1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   95.84%   95.83%   -0.01%     
==========================================
  Files           4        4              
  Lines        3296     3316      +20     
  Branches      402      402              
==========================================
+ Hits         3159     3178      +19     
  Misses         82       82              
- Partials       55       56       +1     
Impacted Files Coverage Δ
zeroconf/__init__.py 92.49% <100.00%> (ø)
zeroconf/test.py 98.86% <100.00%> (+0.01%) ⬆️
zeroconf/asyncio.py 98.72% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3365e1...a05de67. Read the comment docs.

@bdraco

bdraco commented Jun 6, 2021

Copy link
Copy Markdown
Member Author

I should break up the cache clear cleanup into a new PR

@bdraco bdraco force-pushed the answer_uppercase_ptr_questions branch from d933724 to a05de67 Compare June 6, 2021 02:51
@bdraco bdraco merged commit 7a50402 into python-zeroconf:master Jun 6, 2021
@bdraco bdraco deleted the answer_uppercase_ptr_questions branch June 6, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zeroconf.handle_query does not lower case names with PTR queries

2 participants