Break apart Zeroconf.handle_query to reduce branching#462
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
- Coverage 95.63% 95.55% -0.09%
==========================================
Files 4 4
Lines 3255 3260 +5
Branches 402 402
==========================================
+ Hits 3113 3115 +2
- Misses 85 88 +3
Partials 57 57
Continue to review full report at Codecov.
|
This was referenced Jun 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #458
Now that the function is a bit easier to read there are some issues that are apparent:
question.namecomparisons are not lower cased in all circumstances (Zeroconf.handle_query does not lower case names with PTR queries #463)_TYPE_ANYwe never respond with PTRs (is this by design or not?) (Zeroconf.handle_query does respond with PTR records when the query type is ANY #464)