Skip to content

Reduce branching in Zeroconf.handle_query#460

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:reduce_branching_handle_query
Jun 6, 2021
Merged

Reduce branching in Zeroconf.handle_query#460
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:reduce_branching_handle_query

Conversation

@bdraco

@bdraco bdraco commented Jun 5, 2021

Copy link
Copy Markdown
Member

First pass at #458

@bdraco bdraco force-pushed the reduce_branching_handle_query branch 2 times, most recently from 05c20da to 43a3d42 Compare June 5, 2021 23:41
@codecov-commenter

codecov-commenter commented Jun 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #460 (583ef34) into master (6fafdee) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   95.58%   95.63%   +0.05%     
==========================================
  Files           4        4              
  Lines        3261     3255       -6     
  Branches      406      403       -3     
==========================================
- Hits         3117     3113       -4     
+ Misses         86       85       -1     
+ Partials       58       57       -1     
Impacted Files Coverage Δ
zeroconf/__init__.py 92.19% <100.00%> (+0.15%) ⬆️
zeroconf/asyncio.py 98.67% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fafdee...583ef34. Read the comment docs.

@bdraco bdraco force-pushed the reduce_branching_handle_query branch from 43a3d42 to b22d716 Compare June 6, 2021 00:31
@bdraco bdraco force-pushed the reduce_branching_handle_query branch from b22d716 to 583ef34 Compare June 6, 2021 00:32
@bdraco bdraco merged commit 5e24da0 into python-zeroconf:master Jun 6, 2021
@bdraco bdraco deleted the reduce_branching_handle_query branch June 6, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants