Skip to content

Switch to using built-in abstractmethod instead of throwing AbstractMethodException #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdraco wants to merge 1 commit into from
Closed

Switch to using built-in abstractmethod instead of throwing AbstractMethodException #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions zeroconf/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import threading
import time
import warnings
from abc import abstractmethod
from collections import OrderedDict
from typing import Dict, Iterable, List, Optional, Union, cast
from typing import Any, Callable, Set, Tuple # noqa # used in type hints
Expand Down Expand Up @@ -382,10 +383,6 @@ class NamePartTooLongException(Error):
pass


class AbstractMethodException(Error):
pass


class BadTypeInNameException(Error):
pass

Expand Down Expand Up @@ -505,9 +502,9 @@ def __init__(self, name: str, type_: int, class_: int, ttl: Union[float, int]) -
self._expiration_time = self.get_expiration_time(_EXPIRE_FULL_TIME_PERCENT)
self._stale_time = self.get_expiration_time(_EXPIRE_STALE_TIME_PERCENT)

@abstractmethod
def __eq__(self, other: Any) -> bool:
"""Abstract method"""
raise AbstractMethodException

def __ne__(self, other: Any) -> bool:
"""Non-equality test"""
Expand Down Expand Up @@ -552,9 +549,9 @@ def reset_ttl(self, other: 'DNSRecord') -> None:
self._expiration_time = self.get_expiration_time(_EXPIRE_FULL_TIME_PERCENT)
self._stale_time = self.get_expiration_time(_EXPIRE_STALE_TIME_PERCENT)

@abstractmethod
def write(self, out: 'DNSOutgoing') -> None:
"""Abstract method"""
raise AbstractMethodException

def to_string(self, other: Union[bytes, str]) -> str:
"""String representation with additional information"""
Expand Down