RecordUpdateListener now uses update_records instead of update_record#419
Merged
Conversation
bdraco
force-pushed
the
update_records
branch
6 times, most recently
from
a16a69f to
b635880
Compare
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 95.62% 95.83% +0.20%
==========================================
Files 4 4
Lines 3338 3385 +47
Branches 402 407 +5
==========================================
+ Hits 3192 3244 +52
+ Misses 89 84 -5
Partials 57 57
Continue to review full report at Codecov.
|
Member
Author
|
There is still a race condition since we update the cache after we call We need a way to tell the ServiceBrowser to process pending events after the cache has been updated |
bdraco
force-pushed
the
update_records
branch
2 times, most recently
from
049cb13 to
4a6d5de
Compare
bdraco
commented
Jun 2, 2021
bdraco
force-pushed
the
update_records
branch
6 times, most recently
from
5203b2c to
562c6ad
Compare
Member
Author
|
bdraco
force-pushed
the
update_records
branch
8 times, most recently
from
0bf5150 to
14b4e4d
Compare
Member
Author
|
This one needs another set of 👀 I'm going to try to break out the simpler changes into smaller chunks though first to reduce the size of the review |
bdraco
added a commit
to bdraco/python-zeroconf
that referenced
this pull request
Jun 4, 2021
- Prepares for the change from update_record to update_records in python-zeroconf#419
bdraco
added a commit
to bdraco/python-zeroconf
that referenced
this pull request
Jun 5, 2021
- This will be fixed in python-zeroconf#419
bdraco
force-pushed
the
update_records
branch
4 times, most recently
from
4a9de0f to
c7f919a
Compare
bdraco
added a commit
to bdraco/python-zeroconf
that referenced
this pull request
Jun 6, 2021
- This change is not enough to remove the too-many-branches pylint disable, however when combined with python-zeroconf#419 it should no longer be needed
bdraco
added a commit
that referenced
this pull request
Jun 6, 2021
- Adds `add_records` and `remove_records` to `DNSCache` to permit multiple records to be added or removed in one call - This change is not enough to remove the too-many-branches pylint disable, however when combined with #419 it should no longer be needed
bdraco
force-pushed
the
update_records
branch
4 times, most recently
from
b6a07b3 to
3371d8b
Compare
Member
Author
|
May be possible to merge |
bdraco
commented
Jun 6, 2021
Member
Author
|
I was initially worried about this change, but it turns out the problem is actually #476 so this should be good to go once the other issue is fixed. |
This allows the listener to receive all the records that have been updated in a single transaction such as a packet or cache expiry. `update_record` has been deprecated in favor of `update_records` A compatibility shim exists to ensure classes that use `RecordUpdateListener` as a base class continue to have `update_record` called, however they should be updated as soon as possible. A new method `update_records_complete` is now called on each listener when all listeners have completed processing updates and the cache has been updated. This allows ServiceBrowsers to delay calling handlers until they are sure the cache has been updated as its a common pattern to call for ServiceInfo when a ServiceBrowser handler fires.
Member
Author
|
I think we can turn on some more of the PyPy disabled tests as they should be less flakey after this and the other synchronization fixes that I just merged |
bdraco
added a commit
to bdraco/python-zeroconf
that referenced
this pull request
Jun 7, 2021
- The root cause of the test failing should be fixed by python-zeroconf#419 and python-zeroconf#477
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the listener to receive all the records that have
been updated in a single transaction such as a packet or
cache expiry.
update_recordhas been deprecated in favor ofupdate_recordsA compatibility shim exists to ensure classes that use
RecordUpdateListeneras a base class continue to haveupdate_recordcalled, however they should be updatedas soon as possible.
A new method
update_records_completeis now called on eachlistener when all listeners have completed processing updates
and the cache has been updated. This allows ServiceBrowsers
to delay calling handlers until they are sure the cache
has been updated as its a common pattern to call for
ServiceInfo when a ServiceBrowser handler fires.
Fixes #416
Fixes #431
Closes #418
Fixes #456
Closes #457