Support for context managers in Zeroconf and AsyncZeroconf#284
Merged
Conversation
shenek
force-pushed
the
context-managers
branch
3 times, most recently
from
feb2d7e to
5bfbfb5
Compare
Member
|
This seems reasonable considering how often we didn't close zeroconf in the tests which was fixed in #383 |
bdraco
changed the title
bdraco
changed the title
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 95.58% 95.49% -0.10%
==========================================
Files 4 4
Lines 3261 3284 +23
Branches 406 402 -4
==========================================
+ Hits 3117 3136 +19
- Misses 86 89 +3
- Partials 58 59 +1
Continue to review full report at Codecov.
|
Member
|
Thanks @shenek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #177