Skip to content

Duplicate updates fix - #228

Merged
jstasiak merged 2 commits into
python-zeroconf:masterfrom
mattsaxon:Duplicate-updates-fix
Feb 20, 2020
Merged

Duplicate updates fix#228
jstasiak merged 2 commits into
python-zeroconf:masterfrom
mattsaxon:Duplicate-updates-fix

Conversation

@mattsaxon

Copy link
Copy Markdown
Collaborator

The prior code used to send updates even when the new record was identical to the old.

This resulted in duplicate update messages when there was in fact no update (apart from TTL refresh)

The prior code used to send updates even when the new record was identical to the old.

This resulted in duplciate update messages when there was in fact no update (apart from TTL refresh)
@coveralls

coveralls commented Feb 16, 2020

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 93.537% when pulling e2a6b0e on mattsaxon:Duplicate-updates-fix into bef8f59 on jstasiak:master.

@jstasiak jstasiak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jstasiak
jstasiak merged commit d8caa4e into python-zeroconf:master Feb 20, 2020
@jstasiak

jstasiak commented Mar 7, 2020

Copy link
Copy Markdown
Collaborator

This has just been released in 0.24.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants