Refactor out unique assertion - #225
Closed
mattsaxon wants to merge 1 commit into
Closed
Conversation
Merged
jstasiak
reviewed
Feb 3, 2020
| or record.type == _TYPE_AAAA | ||
| ): | ||
| if self.is_type_unique(record.type): | ||
| assert record.unique |
Collaborator
There was a problem hiding this comment.
We could put the assert in the function/method too and call it assert_unique_used_correctly or something I think.
Collaborator
Author
There was a problem hiding this comment.
I considered it, but thought it was more readable as I have it. I pondered it for a while and decided the readability was better than saving the one line. I'd appreciate your view to be honest and could have gone either way.
Collaborator
There was a problem hiding this comment.
That's fair, looks good either way.
jstasiak
approved these changes
Feb 3, 2020
jstasiak
reviewed
Feb 3, 2020
|
|
||
| @staticmethod | ||
| def is_type_unique(type_: int) -> bool: | ||
| return type_ == _TYPE_TXT or type_ == _TYPE_SRV or type_ == _TYPE_A or type_ == _TYPE_AAAA |
Collaborator
There was a problem hiding this comment.
Maybe just type_ in {_TYPE_TXT, _TYPE_SRV, _TYPE_A, _TYPE_AAAA}?
Collaborator
|
Sorry, I forgot about this pull request – since you pushed the commit as part of #228 I merged it from there and this can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per code review comments from #217