fix: keep key= distinct from a valueless key in TXT records - #1813
Open
bboe wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1813 +/- ##
==========================================
- Coverage 99.81% 99.81% -0.01%
==========================================
Files 33 33
Lines 3750 3749 -1
Branches 533 533
==========================================
- Hits 3743 3742 -1
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RFC 6763 6.4: a key with no '=' is a boolean attribute; `key=` is present with an empty value. Collapsing both to None makes them indistinguishable, so a received `key=` re-encodes as a bare `key`. Regression in python-zeroconf#1225 (first released in 0.80.0), which replaced explicit branching on the separator with `value or None`. Restores the behaviour python-zeroconf#226 introduced.
bboe
force-pushed
the
fix/txt-empty-value
branch
from
August 12, 2026 20:23
8edd983 to
3f555e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 6763 6.4: a key with no '=' is a boolean attribute;
key=is present with an empty value. Collapsing both to None makes them indistinguishable, so a receivedkey=re-encodes as a barekey.Regression in #1225 (first released in 0.80.0), which replaced explicit branching on the separator with
value or None. Restores the behaviour #226 introduced.