fix: add TXT record size guard (CVE-2026-48045) - #1809
Open
alor29 wants to merge 1 commit into
Open
Conversation
alor29
changed the title
alor29
force-pushed
the
fix-txt-record-limit
branch
2 times, most recently
from
July 12, 2026 20:25
a12e298 to
8ccc0f2
Compare
alor29
force-pushed
the
fix-txt-record-limit
branch
from
July 13, 2026 11:53
8ccc0f2 to
0ece3f1
Compare
|
For the record, pull request #1751 claims to have fixed CVE-2026-48045. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds explicit guards to
ServiceInfoto prevent oversized DNS TXT records from causing memory exhaustion or crashes. DNS TXT entries are limited to 255 bytes, but previously the code attempted to encode arbitrary lengths, resulting inValueError: bytes must be in range(0, 256).Changes
ServiceInfo.__init__to reject property values longer than 255 bytes._set_propertiesto rejectkey=valuerecords longer than 255 bytes before encoding.Proof of Fix
Impact
This resolves CVE‑2026‑48045 (memory exhaustion via oversized TXT records) and ensures compliance with DNS TXT record limits. It prevents crashes and uncontrolled resource usage when handling malformed inputs.
