Skip to content

test: widen QM follow-up window in info_asking_default test #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
May 20, 2026
+5 −4
Merged

test: widen QM follow-up window in info_asking_default test #1765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@

from . import (
LOOPBACK_FIND_TIMEOUT,
QUICK_REQUEST_TIMEOUT_MS,
QuestionHistoryWithoutSuppression,
_clear_cache,
has_working_ipv6,
Expand Down Expand Up @@ -1191,10 +1190,12 @@ def send(out, addr=const._MDNS_ADDR, port=const._MDNS_PORT):
with patch.object(zeroconf_info, "async_send", send):
aiosinfo = AsyncServiceInfo(type_, registration_name)
# Patch _is_complete so we send multiple times. Under
# `quick_request_timing` both the QU query at 0ms and the QM
# query at ~15ms land well inside QUICK_REQUEST_TIMEOUT_MS.
# `quick_request_timing` the QU query fires at 0ms and the QM
# follow-up at ~11-15ms (10ms _LISTENER_TIME + 1-5ms jitter);
# 300ms absorbs macOS short-sleep quantization so the QM wake
# lands before the loop times out.
with patch("zeroconf.asyncio.AsyncServiceInfo._is_complete", False):
await aiosinfo.async_request(aiozc.zeroconf, QUICK_REQUEST_TIMEOUT_MS)
await aiosinfo.async_request(aiozc.zeroconf, 300)
try:
assert first_outgoing.questions[0].unicast is True # type: ignore[union-attr]
assert second_outgoing.questions[0].unicast is False # type: ignore[attr-defined]
Expand Down
Loading